Skip to content

[SQL] Prevents per row dynamic dispatching and pattern matching when inserting Hive values #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
liancheng wants to merge 2 commits into from
Closed

[SQL] Prevents per row dynamic dispatching and pattern matching when inserting Hive values #2592

liancheng wants to merge 2 commits into from

Conversation

@liancheng
Copy link
Contributor

@liancheng liancheng commented Sep 30, 2014

Builds all wrappers at first according to object inspector types to avoid per row costs.

@SparkQA
Copy link

SparkQA commented Sep 30, 2014

QA tests have started for PR 2592 at commit 4998666.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 30, 2014

QA tests have finished for PR 2592 at commit 4998666.

  • This patch fails unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Sep 30, 2014

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21026/

@SparkQA
Copy link

SparkQA commented Sep 30, 2014

QA tests have started for PR 2592 at commit 9696559.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Sep 30, 2014

QA tests have finished for PR 2592 at commit 9696559.

  • This patch passes unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Sep 30, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/21038/

@marmbrus
Copy link
Contributor

marmbrus commented Oct 1, 2014

I guess this needs to go in after the dynamic partition patch? We have seen speedups from similar fixes in the past. We can ommit a micro benchmark.

@liancheng
Copy link
Contributor Author

liancheng commented Oct 2, 2014

Yes, it should go after the DP PR.

@marmbrus
Copy link
Contributor

marmbrus commented Oct 9, 2014

Thanks! I've merged this to master.

@asfgit asfgit closed this in 3e4f09d Oct 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liancheng @SparkQA @AmplabJenkins @marmbrus